Christoph Hellwig <hch@xxxxxx> writes: > Now that we have REQ_OP_WRITE_ZEROES implemented for all devices that > support efficient zeroing of devices we can remove the call to s/of devices/ > blkdev_issue_discard. This means we only have two ways of zeroing > left and can simply the code. simplify > + * Note that this function may fail with -EOPNOTSUPP if the driver supports > + * efficient zeroing operation, but the device capabilities can only be > + * discovered by trial and error. In this case the caller should call the > + * function again, and it will use the fallback path. Maybe: "Note that this function may fail with -EOPNOTSUPP if the driver signals zeroing offload support but the device fails to process the command (for some devices there is no non-destructive way to verify whether this operation is actually supported). If -EOPNOTSUPP is returned, the caller should retry the blkdev_issue_zeroout() and the fallback path will be used." Otherwise OK. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
