On Mar 28, 2017, at 10:52 AM, jes.sorensen@xxxxxxxxx wrote:
>
> Song Liu <songliubraving@xxxxxx> writes:
>> Currently, --add-journal can be only used to recreate broken journal
>> for arrays with journal since creation. As the kernel code getting
>> more mature, this constraint is no longer necessary.
>>
>> This patch allows --add-journal to add journal to array without
>> journal.
>>
>> Signed-off-by: Song Liu <songliubraving@xxxxxx>
>> ---
>> Manage.c | 9 ---------
>> mdadm.8.in | 5 ++---
>> 2 files changed, 2 insertions(+), 12 deletions(-)
>>
>> diff --git a/Manage.c b/Manage.c
>> index 5c3d2b9..d038b68 100644
>> --- a/Manage.c
>> +++ b/Manage.c
>> @@ -946,7 +946,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
>>
>> /* only add journal to array that supports journaling */
>> if (dv->disposition == 'j') {
>> - struct mdinfo mdi;
>> struct mdinfo *mdp;
>>
>> mdp = sysfs_read(fd, NULL, GET_ARRAY_STATE);
>> @@ -960,14 +959,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
>> pr_err("%s is not readonly, cannot add journal.\n", devname);
>> return -1;
>> }
>> -
>> - sysfs_free(mdp);
>> -
>
> Song,
>
> Sorry for nagging you again on this one, however removing
> sysfs_free(mdp) means you are leaking mbp here.
>
> Cheers,
> Jes
Oops... new patch coming...
Thanks,
Song
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
