On 28/03/17 16:02, Ming Lei wrote: >> What I meant is that a future change to the function might cause >> > another bug to go unnoticed later. > What is the future change? And what is another bug? Please don't suppose or > assume anything in future. What was that about some American General demanding a list of "unknown unknowns"? > > BTW, I don't think it is a problem, and anyone who want to change the code > much should understand it first, right? > I'm very sorry, but I think you are assuming facts not in evidence (or rather, facts that the evidence says are wrong). In real life, it is normal for people to change things without understanding them. Are you saying that *you* - a couple of years down the line - will remember this bit of code, and will block a mistaken patch? What Arnd is doing is commonly called "defensive programming", and unfortunately reality shows us that it is usually worth its weight in gold. That's why you put ASSERTs in code - so that if somebody does something stupid by accident, it blows up. This is just more of the same. Cheers, Wol -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
