Zhilong Liu <zlliu@xxxxxxxx> writes: > Monitor: ensure that the device should be a block > device when uses --wait parameter, such as the 'f' > and 'd' type file would be triggered core dumped. > such as: ./mdadm --wait /dev/md/ I modified the patch description here to make it easier to read. > Reviewed-by: NeilBrown <neilb@xxxxxxxx> > Signed-off-by: Zhilong Liu <zlliu@xxxxxxxx> > --- > Monitor.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Monitor.c b/Monitor.c > index 802a9d9..f8850d3 100644 > --- a/Monitor.c > +++ b/Monitor.c > @@ -1002,7 +1002,12 @@ int Wait(char *dev) > strerror(errno)); > return 2; > } > - strcpy(devnm, stat2devnm(&stb)); > + char *tmp = stat2devnm(&stb); Please do not declare variables in the middle of the codeflow, that is extremely bad programming practice. I fixed this up and applied the patch. Thanks, Jes -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
