Re: [PATCH v2 1/2] md/raid5: Add change_consistency_policy to raid4 and raid6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/24/2017 03:45 PM, Shaohua Li wrote:
> On Thu, Mar 16, 2017 at 03:14:08PM -0700, Song Liu wrote:
>> Add change_consistency_policy to raid6_personality and
>> raid4_personality.
>>
>> Signed-off-by: Song Liu <songliubraving@xxxxxx>
>> ---
>>  drivers/md/raid5.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> index 88cc898..7a6e7ea 100644
>> --- a/drivers/md/raid5.c
>> +++ b/drivers/md/raid5.c
>> @@ -8408,6 +8408,7 @@ static struct md_personality raid6_personality =
>>  	.quiesce	= raid5_quiesce,
>>  	.takeover	= raid6_takeover,
>>  	.congested	= raid5_congested,
>> +	.change_consistency_policy = raid5_change_consistency_policy,
>>  };
>>  static struct md_personality raid5_personality =
>>  {
>> @@ -8456,6 +8457,7 @@ static struct md_personality raid4_personality =
>>  	.quiesce	= raid5_quiesce,
>>  	.takeover	= raid4_takeover,
>>  	.congested	= raid5_congested,
>> +	.change_consistency_policy = raid5_change_consistency_policy,
>>  };
> sorry for the late reply.
> 
> the change_consistency_policy is only for raid5 for a reason, ppl is only for
> raid5. I think you need to filter out raid 4/6 in
> raid5_change_consistency_policy for ppl.

Not necessarily. There is a check in ppl_init_log() that won't allow
starting ppl if it's not raid5. But it certainly wouldn't hurt.

Thanks,
Artur
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux