Re: [PATCH] md/r5cache: fix set_syndrome_sources()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Mar 13, 2017, at 1:58 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> 
> On Mon, Mar 13, 2017 at 1:44 PM, Song Liu <songliubraving@xxxxxx> wrote:
>> With srctype == SYNDROME_SRC_WRITTEN, we need include both
>> dev with non-null ->written and dev with R5_InJournal.
>> 
> 
> Can you say a bit more about what this fixes? How does this bug
> manifest itself (user visible effect), and should this be marked for
> -stable?

Before this patch, device InJournal will be included in prexor 
(SYNDROME_SRC_WANT_DRAIN) but not in reconstruct (SYNDROME_SRC_WRITTEN). 
So it will break parity. 

This fixes logic in 1e6d690b9334b7e1b31d25fd8d93e980e449a5f9. 

Thanks,
Song
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux