On Wed, Mar 08 2017, Zhilong Liu wrote:
> mdadm: it would be better to check --level ealier,
> because it would fall to different prompt if user
> forgets to specify the --level. such as:
> ./mdadm -CR /dev/md0 -b internal -n2 -x1 /dev/loop[0-2]
When I run that command I get:
mdadm: a RAID level is needed to create an array.
What do you get?
NeilBrown
>
> Signed-off-by: Zhilong Liu <zlliu@xxxxxxxx>
>
> diff --git a/Create.c b/Create.c
> index 9a951b0..beec29f 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -125,10 +125,6 @@ int Create(struct supertype *st, char *mddev,
> memset(&info, 0, sizeof(info));
> if (s->level == UnSet && st && st->ss->default_geometry)
> st->ss->default_geometry(st, &s->level, NULL, NULL);
> - if (s->level == UnSet) {
> - pr_err("a RAID level is needed to create an array.\n");
> - return 1;
> - }
> if (s->raiddisks < 4 && s->level == 6) {
> pr_err("at least 4 raid-devices needed for level 6\n");
> return 1;
> diff --git a/mdadm.c b/mdadm.c
> index 19a06db..ad24bdf 100644
> --- a/mdadm.c
> +++ b/mdadm.c
> @@ -350,6 +350,12 @@ int main(int argc, char *argv[])
> pr_err("Must give -a/--add for devices to add: %s\n", optarg);
> exit(2);
> }
> + if (devs_found > 0 && s.level == UnSet && !devmode) {
> + if (mode == CREATE || mode == BUILD) {
> + pr_err("a RAID level is needed to create or build an array.\n");
> + exit(2);
> + }
> + }
> dv = xmalloc(sizeof(*dv));
> dv->devname = optarg;
> dv->disposition = devmode;
> --
> 2.10.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
