On Tue, Feb 28 2017, Zhilong Liu wrote: > 1. use 'Tab' as the code style. > 2. arrange the testing steps and provide the 'main' entrance. > 3. draft the log_save feature, it captures the /proc/mdstat, > md superblock info, bitmap info and the detail dmesg. > 4. modified the mdadm() func, adding the operation that clear > the superblock when create or build one new array, and it > would exit testing when mdadm command returned non-0 value. > 5. delete no_errors() func, it only used in tests/04update-uuid, > I recommend the new mdadm() using method. > 6. delete fast_sync() func. > 7. testdev(), add the object file checking, otherwise this command > would create one regular file, it's one trouble thing. > 8. add dmesg checking in do_test() func, it's necessary to check > dmesg whether or not printed abnormal message. > 9. add checking conditions in main(), such as $pwd/raid6check need > exists, here is a prompt to remind users to 'make everything' > before testing; the $targetdir should mount under ext[2-4] FS, > because the external bitmap only supports ext, the bmap() API > of bitmap.c doesn't exist in all filesystem, such as btrfs. > > Signed-off-by: Zhilong Liu <zlliu@xxxxxxxx> I haven't looked at this patch in any great detail, but I just wanted to say I think it is great that 'test' is getting some attention like this. I sort of just grew over the years without any clear plan. It probably has all sorts of strange things in it that don't make a lot of sense any more. So I've very happy for you to rip it apart and put it together is a more coherent form. Thanks! Acked-by: NeilBrown <neilb@xxxxxxxx> NeilBrown
Attachment:
signature.asc
Description: PGP signature
