On Fri, Feb 24, 2017 at 11:15:11AM +0800, Guoqing Jiang wrote: > md-cluster.h is already included in md.h, so remove > the redundant one and we don't want to cross include > header file too. > > Reviewed-by: NeilBrown <neilb@xxxxxxxx> > Signed-off-by: Guoqing Jiang <gqjiang@xxxxxxxx> It would be better md.h doesn't include md-cluster.h and include md-cluster.h in required .c files. > --- > drivers/md/md-cluster.c | 1 - > drivers/md/md-cluster.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c > index 2b13117fb918..03c38ed222ce 100644 > --- a/drivers/md/md-cluster.c > +++ b/drivers/md/md-cluster.c > @@ -16,7 +16,6 @@ > #include <linux/raid/md_p.h> > #include "md.h" > #include "bitmap.h" > -#include "md-cluster.h" > > #define LVB_SIZE 64 > #define NEW_DEV_TIMEOUT 5000 > diff --git a/drivers/md/md-cluster.h b/drivers/md/md-cluster.h > index e765499ba591..8f26a5e80810 100644 > --- a/drivers/md/md-cluster.h > +++ b/drivers/md/md-cluster.h > @@ -3,8 +3,6 @@ > #ifndef _MD_CLUSTER_H > #define _MD_CLUSTER_H > > -#include "md.h" > - > struct mddev; > struct md_rdev; > > -- > 2.6.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
