Hi, Jes; I just wanted to ping and see if this could get a review: On 02/14/2017 03:50 PM, Zhilong Liu wrote:
mdadm --wait-clean /dev/mdX, the dev should be a block file, otherwise fd2devnm returns NULL and triggers core dumped. Signed-off-by: Zhilong Liu <zlliu@xxxxxxxx> diff --git a/Monitor.c b/Monitor.c index 802a9d9..d16ac49 100644 --- a/Monitor.c +++ b/Monitor.c @@ -1060,7 +1060,17 @@ int WaitClean(char *dev, int sock, int verbose) struct mdinfo *mdi; int rv = 1; char devnm[32]; + struct stat stb;+ if (stat(dev, &stb) != 0) {+ pr_err("Cannot find %s: %s\n", dev, + strerror(errno)); + return 2; + } + if ((S_IFMT & stb.st_mode) != S_IFBLK) { + pr_err("%s is not a block device.\n", dev); + return 2; + } fd = open(dev, O_RDONLY); if (fd < 0) { if (verbose)
-- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
