On Mon, Jan 30, 2017 at 07:59:47PM +0100, Artur Paszkiewicz wrote:
> Include information about PPL location and size into mdp_superblock_1
> and copy it to/from rdev. Because PPL is mutually exclusive with bitmap,
> put it in place of 'bitmap_offset'. Add a new flag MD_FEATURE_PPL for
> 'feature_map', analogically to MD_FEATURE_BITMAP_OFFSET. Add MD_HAS_PPL
> to mddev->flags to indicate that PPL is enabled on an array.
>
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@xxxxxxxxx>
> ---
> drivers/md/md.c | 15 +++++++++++++++
> drivers/md/md.h | 8 ++++++++
> drivers/md/raid0.c | 3 ++-
> drivers/md/raid1.c | 3 ++-
> include/uapi/linux/raid/md_p.h | 18 ++++++++++++++----
> 5 files changed, 41 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 85ac98417a08..e96f73572e23 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -1566,6 +1566,12 @@ static int super_1_load(struct md_rdev *rdev, struct md_rdev *refdev, int minor_
> } else if (sb->bblog_offset != 0)
> rdev->badblocks.shift = 0;
>
> + if (le32_to_cpu(sb->feature_map) & MD_FEATURE_PPL) {
> + rdev->ppl.offset = (__s16)le16_to_cpu(sb->ppl.offset);
> + rdev->ppl.size = le16_to_cpu(sb->ppl.size);
> + rdev->ppl.sector = rdev->sb_start + rdev->ppl.offset;
> + }
> +
> if (!refdev) {
> ret = 1;
> } else {
> @@ -1678,6 +1684,9 @@ static int super_1_validate(struct mddev *mddev, struct md_rdev *rdev)
>
> if (le32_to_cpu(sb->feature_map) & MD_FEATURE_JOURNAL)
> set_bit(MD_HAS_JOURNAL, &mddev->flags);
> +
> + if (le32_to_cpu(sb->feature_map) & MD_FEATURE_PPL)
> + set_bit(MD_HAS_PPL, &mddev->flags);
I think we should check wrong configuration and bail out. For example, both
MD_FEATURE_PPL and MD_FEATURE_BITMAP_OFFSET set, or both MD_FEATURE_PPL and
MD_FEATURE_JOURNAL set.
Thanks,
Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
