Mariusz Dabrowski <mariusz.dabrowski@xxxxxxxxx> writes: > For 4K disks 'endofpart' is an index of the last 4K sector used by partition. > mdadm is using number of 512-byte sectors, so value returned by > get_last_partition_end must be multiplied by 8 for devices with 4K sectors. > Also, unused 'ret' variable has been removed. > > Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@xxxxxxxxx> > --- > util.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) I am a little wary of this since I don't have any 4k sector drivers to test with, so I will come yelling at you if this breaks something :) > diff --git a/util.c b/util.c > index 883eaa4..46c1280 100644 > --- a/util.c > +++ b/util.c > @@ -1430,6 +1430,7 @@ static int get_last_partition_end(int fd, unsigned long long *endofpart) > struct MBR boot_sect; > unsigned long long curr_part_end; > unsigned part_nr; > + unsigned int sector_size; > int retval = 0; > > *endofpart = 0; > @@ -1469,6 +1470,9 @@ static int get_last_partition_end(int fd, unsigned long long *endofpart) > /* Unknown partition table */ > retval = -1; > } > + /* calculate number of 512-byte blocks */ > + if (get_dev_sector_size(fd, NULL, §or_size)) > + *endofpart *= sector_size/512; I really would prefer to see a parenthesis around this here and use of proper spacing. Thanks, Jes -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
