On Wed, Dec 07, 2016 at 09:42:05AM -0800, Song Liu wrote: > r5l_recovery_create_empty_meta_block() creates crc for the empty > metablock. After the metablock is updated, we need clear the > checksum before recalculate it. applied this one. However, I moved out checksum calculation from r5l_recovery_create_empty_meta_block. We should calculate checksum after all fields in meta block is updated. Thanks, Shaohua > Signed-off-by: Song Liu <songliubraving@xxxxxx> > --- > drivers/md/raid5-cache.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c > index c3b3124..875f963 100644 > --- a/drivers/md/raid5-cache.c > +++ b/drivers/md/raid5-cache.c > @@ -2117,7 +2117,9 @@ r5c_recovery_rewrite_data_only_stripes(struct r5l_log *log, > } > } > mb->meta_size = cpu_to_le32(offset); > - mb->checksum = crc32c_le(log->uuid_checksum, mb, PAGE_SIZE); > + mb->checksum = 0; > + mb->checksum = cpu_to_le32(crc32c_le(log->uuid_checksum, > + mb, PAGE_SIZE)); > sync_page_io(log->rdev, ctx->pos, PAGE_SIZE, page, > REQ_OP_WRITE, WRITE_FUA, false); > sh->log_start = ctx->pos; > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
