On Tue, Dec 06 2016, Artur Paszkiewicz wrote: > Add a source file for the new policy implementation and allow selecting > the policy based on the policy_type parameter in r5l_init_log(). > > Introduce a new flag for rdev state flags to allow enabling the new > policy from userspace. This seems odd. Why is this a per-device flag? It makes sense for "journal" to be a per-device flag, because only one device is the journal device and it is obviously different from the others. But with the ppl, all devices serve as journal devices. So we would need to set journal_ppl on all devices? What happens if you set it on some, but not others? I see you get an error. I think some sort of array-wide setting would make more sense, would it not? And what is an RWH??? A Really Weird Handle ?? I guess it is probably a Raid5 Write Hole ? At the very least there should be a comment explaining this when you define the enum. (remember, you are trying to make it easier for reviewers). It might almost make sense for bitmap/metadata to be used here. It can currently be "external" "internal" "clustered". Allow also "journalled" or "partial-partiy-log" ??? Maybe not ... but I'd definitely prefer a global setting, and one that didn't use an obscure abbreviation. NeilBrown
Attachment:
signature.asc
Description: PGP signature
