On Thu, Dec 01 2016, Robert LeBlanc wrote:
> Refactor raid1_make_request to make read and write code in their own
> functions to clean up the code.
There is a change in here that is more than just a refactoring.
You have moved the wait_barrier() call from after the checks on
->suspend_{lo,hi} to before.
If a write was sent to a suspended region, this will block any pending
resync until the suspended region is moved.
The previous code won't block resync in this case.
I cannot see that this would actually have any practical significance,
as I don't think the suspend_hi/lo settings are used at all for raid1.
I'm less certain about the ->area_resyncing() test, though that probably
isn't a problem.
But it should at least be noted in the change-log that there is
potentially a functional change here.
Thanks,
NeilBrown
Attachment:
signature.asc
Description: PGP signature
