On Mon, Nov 21, 2016 at 12:19:43PM +1100, Neil Brown wrote: > There are 2 problems with using bi_phys_segments as a counter > 1/ we only use 16bits, which limits bios to 256M > 2/ it is poor form to reuse a field like this. It interferes > with other changes to bios. > > We need to clean up a few things before we can change the use the > counter which is now available inside a bio. > > I have only tested this lightly. More review and testing would be > appreciated. So without the accounting, we: - don't do bio completion trace - call md_write_start/md_write_end excessively, which involves atomic operation. Not big problems. But we are actually reusing __bi_remaining, I'm wondering why we not explicitly reuse it. Eg, adds bio_dec_remaining_return() and uses it like raid5_dec_bi_active_stripes. Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
