On Thu, Nov 17 2016, Christoph Hellwig wrote:
> On Mon, Nov 14, 2016 at 04:30:21PM +1100, NeilBrown wrote:
>> raid5 already has this, as does dm.
>> linear and raid0 do no see completions, only bio_chain_end() or bio_endio()
>> see those.
>> So just add it for raid1 and raid10.
>>
>> Between
>> Commit: 3a366e614d08 ("block: add missing block_bio_complete() tracepoint")
>> and
>> Commit: 0a82a8d132b2 ("Revert "block: add missing block_bio_complete() tracepoint"")
>> in the 3.9-rc series, this was done centrally in bio_endio().
>> Until/unless that is resurected, do the tracing in the md/raid code.
>
> We're working on getting it back for 4.10, so please don't add these
> tracepoints to the MD driver for now. Next time please also ask
> linux-block first and/or Cc the list on a patch like this.
Oh good, thanks for letting me know. I'll drop that one.
Do you know if there is any plan to include trace_block_split() in
bio_split()??
Thanks,
NeilBrown
Attachment:
signature.asc
Description: PGP signature
