On Thu, Nov 10, 2016 at 12:46:23PM -0800, Song Liu wrote: > RMW of r5c write back cache uses an extra page to store old data for > prexor. handle_stripe_dirtying() allocates this page by calling > alloc_page(). However, alloc_page() may fail. > > To handle alloc_page() failures, this patch adds a small mempool > in r5l_log. When alloc_page fails, the code tries to allocate a > page from the mempool. this is too complicated. Can we just do rcw instead of rmw if page allocation fails? This way we don't need allocate the memory. This will cause more IO but since this a rare memory allocation failure case, I think it should be ok. Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
