Re: [md PATCH 4/4] md/bitmap: Don't write bitmap while earlier writes might be in-flight

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 04, 2016 at 04:46:03PM +1100, Neil Brown wrote:
> As we don't wait for writes to complete in bitmap_daemon_work, they
> could still be in-flight when bitmap_unplug writes again.  Or when
> bitmap_daemon_work tries to write again.
> This can be confusing and could risk the wrong data being written last.

Applied the first 3 patches, thanks!

This one seems not completely solving the race condition. It's still possible
bitmap_daemon_work clears BITMAP_PAGE_NEEDWRITE but hasn't dispatch the IO yet,
bitmap_unplug then does nothing and thinks bitmap is updated to disk. Why don't
we add locking here?

Thanks,
Shaohua 
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux