On 11/02/2016 04:16 AM, NeilBrown wrote:
This series removes all printk() calls from md code, preferring
pr_warn(), pr_err() etc.
All strings that were split over multiple lines are not joined
back together because being able to search for a message is more
important that not having long lines in the code.
Lots of printk(KERN_DEBUG... are not pr_debug() which means the
messages won't get printed unless they are explicitly disabled.
I included some rough guidelines on which pr_* to choose in md.c.
Many things became pr_debug(), most of the rest are pr_warn().
pr_err() and pr_crit() are used sparingly.
I simplified some code in multipath.c too.
A particular benefit of this is that the various "print_conf()"
functions are not silent by default.
On very large arrays (raid10 with hundreds of devices), these can
be very noisy.
Any specify reason why you didn't move to use dev_*() style of errors?
Generally I prefer having the messages prefixed with the device which
caused them; making debugging _so_ much easier ...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
