On Mon, Oct 17, 2016 at 04:29:09PM +0200, Tomasz Majchrzak wrote:
> Add new rdev flag which external metadata handler can use to switch
> on/off bad block support. If new bad block is encountered, notify it via
> rdev 'unacknowledged_bad_blocks' sysfs file. If bad block has been
> cleared, notify update to rdev 'bad_blocks' sysfs file.
>
> Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@xxxxxxxxx>
> Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@xxxxxxxxx>
> ---
> drivers/md/md.c | 22 ++++++++++++++++++++--
> drivers/md/md.h | 3 +++
> 2 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index eac84d8..f375d1b 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2568,6 +2568,10 @@ state_show(struct md_rdev *rdev, char *page)
> len += sprintf(page+len, "%sreplacement", sep);
> sep = ",";
> }
> + if (test_bit(ExternalBbl, &flags)) {
> + len += sprintf(page+len, "%sexternal_bbl", sep);
> + sep = ",";
> + }
that sep assignment isn't needed, please delete it and the previous occurences.
> return len+sprintf(page+len, "\n");
> }
> @@ -2708,6 +2712,14 @@ state_store(struct md_rdev *rdev, const char *buf, size_t len)
> }
> } else
> err = -EBUSY;
> + } else if (cmd_match(buf, "external_bbl") && (rdev->mddev->external)) {
> + set_bit(ExternalBbl, &rdev->flags);
> + rdev->badblocks.shift = 0;
> + err = 0;
> + } else if (cmd_match(buf, "-external_bbl") && (rdev->mddev->external)) {
> + clear_bit(ExternalBbl, &rdev->flags);
> + rdev->badblocks.shift = -1;
> + err = 0;
How is this safe? If md is clearing badblocks and in the meaningtime we set
badblocks.shift = -1 here, we have a trouble.
Thanks,
Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
