On Thu, Sep 22, 2016 at 05:07:55PM -0700, Gayatri Kammela wrote:
> Specifying the aligned attributes to the char recovi[PAGE_SIZE]
> and char recovi[PAGE_SIZE] arrays, so that all malloc memory is page
> boundary aligned.
>
> Without these alignment attributes, the test causes a segfault in
> userspace when the NDISKS are changed to 4 from 16.
>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@xxxxxxxxx>
> ---
> lib/raid6/test/test.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/raid6/test/test.c b/lib/raid6/test/test.c
> index 3bebbabdb510..32a00f11ac50 100644
> --- a/lib/raid6/test/test.c
> +++ b/lib/raid6/test/test.c
> @@ -21,12 +21,13 @@
>
> #define NDISKS 16 /* Including P and Q */
>
> -const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(256)));
> +const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
> struct raid6_calls raid6_call;
>
> char *dataptrs[NDISKS];
> char data[NDISKS][PAGE_SIZE];
shouldn't this one be page aligned too?
> -char recovi[PAGE_SIZE], recovj[PAGE_SIZE];
> +char recovi[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
> +char recovj[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
>
> static void makedata(int start, int stop)
> {
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
