Thanks Adam and Jes.
These looks good to me.
PS: we will make “add-journal” more flexible, and revise the man page accordingly.
Song
>> On 8/15/16, 7:42 AM, "Jes Sorensen" <Jes.Sorensen@xxxxxxxxxx> wrote:
Adam Goryachev <mailinglists@xxxxxxxxxxxxxxxxxxxxxx> writes:
> On 13/08/2016 00:58, Jes Sorensen wrote:
>> Song Liu <songliubraving@xxxxxx> writes:
>>> Add the following to man page:
>>>
>>> --add-journal
>>> Recreate journal for RAID-4/5/6 array that losts journal
>>> devices. In current implementation, this command cannot
>>> add journal to an array that had failed journal. To
>>> avoid interrupting on-going write opertions,
>>> --add-journal only works for array in Read-Only state.
>>>
>>> Reported-by: Yi Zhang <yizhan@xxxxxxxxxx>
>>> Signed-off-by: Song Liu <songliubraving@xxxxxx>
>>> Signed-off-by: Shaohua Li <shli@xxxxxx>
>>> ---
>>> mdadm.8.in | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>> Applied, with a few minor mods.
>>
>> I changed it to say this, I hope you are fine with that:
>>
>> "Recreate journal for RAID-4/5/6 array that lost a journal device. In the
>> current implementation, this command cannot add a journal to an array
>> that had a failed journal. To avoid interrupting on-going write
>> opertions, "
> I think this might be more correct:
>
> "Recreate journal for RAID-4/5/6 array that lost a journal device. In the
> current implementation, this command cannot add a journal to an array
> that *has* a failed journal. To avoid interrupting on-going write
> *operations*, "
>
>
> Note the two words modified have **
> has mean currently, if it had (past) a failed journal, but that has
> already been fixed, then it currently has a working journal, and so I
> assume this patch is not relevant. It's only related to if the array
> is currently missing a journal...
> The second operations is just a typo...
>
> Hope you don't mind my jumping in here, I can't help much with code,
> but hopefully contribution is still helpful.
If Song is happy with this and you send me a patch, I'll be happy to
apply it.
Cheers,
Jes
��.n��������+%������w��{.n�����{����w��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
