Xiao Ni <xni@xxxxxxxxxx> writes:
> Hi Jes
>
> Thanks for reminding me. This is the patch after modifying.
>
> When reshaping a 3 drives raid5 to 4 drives raid5, there is a chance that
> it can't start the reshape. If the disks are not enough to have spaces for
> relocating the data_offset, it needs to call start_reshape and then run
> mdadm --grow --continue by systemd. But mdadm --grow --continue fails
> because it checkes that info->reshape_active is 0.
>
> The info->reshape_active is got from the superblock of underlying devices.
> Function start_reshape write reshape to /sys/../sync_action. Before writing
> latest superblock to underlying devices, mdadm --grow --continue is called.
> There is a chance info->reshape_active is 0. We should wait for superblock
> updating more time before calling Grow_continue.
>
> Regards
> Xiao
Xiao,
Sorry but this version doesn't compile:
Grow.c: In function 'Grow_continue_command':
Grow.c:4838:12: error: 'cnt' undeclared (first use in this function)
} while (cnt-- > 0);
^
Also please try to separate the email comments from the patch message. I
normally save the message and use git am to integrate it.
Thanks,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
