On Mon, May 09 2016, Shaohua Li wrote: > On Mon, May 09, 2016 at 09:33:39AM +1000, Eyal Lebedinsky wrote: >> I do not see how this change makes it clearer. The original form is actually a very common and clear >> scan an array in reverse order > > People always have different opinions for this stuff. When I read '--j' or > 'j--', I always think extra time what the value of j is. So for me the change > actually makes the code more readable :) If the goal is to make the code more readable, you may as well make it: for (j = 0; i < ->raid_disk; j++) That will be clearer to most people than the current code, which I don't think is very much clearer than the original (maybe a little bit). NeilBrown
Attachment:
signature.asc
Description: PGP signature
