On 04/21/2016 03:00 PM, kbuild test robot wrote:
drivers/md/bitmap.c:2049:6-11: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Oops, I missed it.
Acked-by: Guoqing Jiang <gqjiang@xxxxxxxx>
Thanks,
Guoqing
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Guoqing Jiang <gqjiang@xxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---
bitmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -2045,8 +2045,7 @@ int bitmap_resize(struct bitmap *bitmap,
/* deallocate the page memory */
for (k = 0; k < page; k++) {
- if (new_bp[k].map)
- kfree(new_bp[k].map);
+ kfree(new_bp[k].map);
}
/* restore some fields from old_counts */
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
