The 'size' field of mdu_disk_info_t is 32bit and should not be used except for legacy ioctls. super-ddf got this wrong :-( This change makes it possible to create ddf arrays which used more than 2TB of each device. Reported-by: Dan Russell <dpr@xxxxxxx> Signed-off-by: NeilBrown <neilb@xxxxxxxx> --- super-ddf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/super-ddf.c b/super-ddf.c index faaf0a7ca9e0..0e00d17dd169 100644 --- a/super-ddf.c +++ b/super-ddf.c @@ -2688,10 +2688,10 @@ static int init_super_ddf_bvd(struct supertype *st, free(vcl); return 0; } - vc->blocks = cpu_to_be64(info->size * 2); + vc->blocks = cpu_to_be64(size * 2); vc->array_blocks = cpu_to_be64( calc_array_size(info->level, info->raid_disks, info->layout, - info->chunk_size, info->size*2)); + info->chunk_size, size*2)); memset(vc->pad1, 0xff, 8); vc->spare_refs[0] = cpu_to_be32(0xffffffff); vc->spare_refs[1] = cpu_to_be32(0xffffffff); -- 2.7.2
Attachment:
signature.asc
Description: PGP signature
