Hi Xiao,
On Sat, Feb 6, 2016 at 3:17 AM, Xiao Ni <xni@xxxxxxxxxx> wrote:
>
>
> ----- Original Message -----
>> From: "Maxin B. John" <maxin.john@xxxxxxxxx>
>> To: linux-raid@xxxxxxxxxxxxxxx
>> Cc: "Maxin B. John" <maxin.john@xxxxxxxxx>
>> Sent: Saturday, February 6, 2016 6:28:18 AM
>> Subject: [PATCH 3/3][mdadm] Monitor.c: fix compiler error with x32 toolchain
>>
>> From: "Maxin B. John" <maxin.john@xxxxxxxxx>
>>
>> With x32 toolchain, this code caused the below listed error:
>>
>> | Monitor.c: In function 'check_array':
>> | Monitor.c:545:16: error: comparison between signed and unsigned
>> integer expressions [-Werror=sign-compare]
>> | if (st->utime == array.utime &&
>>
>> Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx>
>> ---
>> Monitor.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Monitor.c b/Monitor.c
>> index f19c2e5..748d61b 100644
>> --- a/Monitor.c
>> +++ b/Monitor.c
>> @@ -542,7 +542,7 @@ static int check_array(struct state *st, struct
>> mdstat_ent *mdstat,
>> alert("NewArray", st->devname, NULL, ainfo);
>> }
>>
>> - if (st->utime == array.utime &&
>> + if ((unsigned long)st->utime == array.utime &&
>> st->failed == array.failed_disks &&
>> st->working == array.working_disks &&
>> st->spare == array.spare_disks &&
>
> Hi Maxin
>
> I sent the patch some days ago and I think it's not what Jes wanted. You can
> see the mails in the list. I'll send the patch again.
>
Ah, I missed it. Thanks for fixing it.
> Best Regards
> Xiao
Thanks and Regards,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
