On Wed, Jan 06, 2016 at 12:54:28PM +1100, NeilBrown wrote:
> On Tue, Jan 05 2016, Shaohua Li wrote:
>
> > If there are spaces in journal, we do nothing. Likely a typo merging
> > recent io_unit mempool patch.
>
> Very likely.
>
> I think the same effect as your patch can be achieved with
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 55a905e56e8a..6d2b4789a928 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -500,7 +500,7 @@ int r5l_write_stripe(struct r5l_log *log, struct stripe_head *sh)
> spin_unlock(&log->no_space_stripes_lock);
>
> r5l_wake_reclaim(log, reserve);
> -
> + } else {
> ret = r5l_log_stripe(log, sh, data_pages, parity_pages);
> if (ret) {
> spin_lock_irq(&log->io_list_lock);
>
> Are you OK with me just merging that into the offending patch?
sure, please go ahead
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
