On Wed, Jan 06, 2016 at 12:12:05PM +1100, NeilBrown wrote: > On Wed, Jan 06 2016, Shaohua Li wrote: > > > When we hotadd journal for array which isn't created with journal, the > > array might be running write requests. Such writes aren't protected by > > journal yet, so we can't skip disk flush. There is no easy way to know > > when all such writes are finished, but the time should be enough after > > reclaim runs once. > > There is an easy way to know when such writes are finished. > Call mddev_suspend(mddev). This is used for the more intrusive > reconfiguration such as initiating a reshape. > I think it would be perfectly appropriate to > call mddev_suspend() > attach the journal > call mddev_resume() hot add/remove disk is called in raid5d, we can't wait IO there. mddev_suspend() will wait IO. So we can't call mddev_suspend() Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
