On Wed, Dec 16 2015, Shaohua Li wrote: >> And I'm a bit uncertain about setting rdev->raid_disk to >> mddev->raid_disks. >> I thought we decided that "Journal" devices had a different namespace >> for raid_disk than data disks, so ->raid_disk of 0 was appropriate? >> Setting the journal raid_disk to mddev->raid_disks might cause problems >> when we ultimately support reshaping an array with a journal. > > 0 will introduce confusion in sysfs entry, eg, which disk should > xxx/md/rd0 point to? Create a special sys file? This appears the only > reason we don't use 0. sysfs_link_rdev already avoids the "rd%d" link of Replacement devices. Change it and sysfs_unlink_rdev to ignore the Journal device too. Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
