Jes.Sorensen@xxxxxxxxxx writes: > From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> > > Hi, > > Bill Kuzeja reported a problem to me about data corruption when > repeatedly removing and re-adding devices in raid1 arrays. It showed > up to be caused by the return value of submit_bio_wait() being handled > incorrectly. Tracking this down is credit of Bill! > > Looks like commit 9e882242c6193ae6f416f2d8d8db0d9126bd996b changed the > return of submit_bio_wait() to return != 0 on error, whereas before it > returned 0 on error. > > This fix should be suitable for -stable as far back as 3.9 3.10? Thanks to both of you! I took the liberty of changing the patches a little so they are now: - if (submit_bio_wait(WRITE, wbio) == 0) + if (submit_bio_wait(WRITE, wbio) < 0) because when there is no explicit test I tend to expect a Bool but these values are not Bool. Patches are in my for-linus branch and will be forwarded sometime this week. This bug only causes a problem when bad-block logs are active, so hopefully it won't have caused too much corruption yet -- you would need to be using a newish mdadm. Thanks, NeilBrown > > Cheers, > Jes > > Jes Sorensen (2): > md/raid1: submit_bio_wait() returns 0 on success > md/raid10: submit_bio_wait() returns 0 on success > > drivers/md/raid1.c | 2 +- > drivers/md/raid10.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
