On Thu, Oct 08, 2015 at 05:04:54PM +1100, Neil Brown wrote: > Having two disks with ->raid_disk==0 does seem a little weird, but we do > already have that in some cases. > When you have a hot-replace going, both the original and the replacement > have the same ->raid_disk numbers. They can be distinguished by the > Replacement flag. > I'm suggesting the same (sort of) for journals, and distinguish by the > Journal flag. > > I did quick audit and just found setup_conf, run() and md_update_sb(). > If you could do an audit to that would be good. I'd be surprised if you > find many more places where Journal needs to be tested with ->raid_disk. Overloading positive numbers for the journal disk sounds like a bad idea to me as it will cause a lot of confusion. I'd rather assign specific negative values to special roles outside the actual rate. This will require an initial audit, but give us nicely understandable rules later on. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
