Re: [PATCH 2/3] md-cluster: Improve md_reload_sb to be less error prone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Goldwyn,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: i386-defconfig (attached as .config)
reproduce:
  git checkout 825961765139461e82fb00395588061f26b21693
  # save the attached .config to linux build tree
  make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/sched.h:17,
                    from include/linux/kthread.h:5,
                    from drivers/md/md.c:35:
   drivers/md/md.c: In function 'check_sb_changes':
>> include/linux/kern_levels.h:4:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'sector_t {aka long long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^
   include/linux/printk.h:259:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^
>> drivers/md/md.c:8975:3: note: in expansion of macro 'pr_info'
      pr_info("%s:%d recovery_cp changed from %lu to %lu\n", __func__,
      ^

vim +/pr_info +8975 drivers/md/md.c

  8959				}
  8960				/* device faulty
  8961				 * We just want to do the minimum to mark the disk
  8962				 * as faulty. The recovery is performed by the
  8963				 * one who initiated the error.
  8964				 */
  8965				if ((role == 0xfffe) || (role == 0xfffd)) {
  8966					__md_error(mddev, rdev2, false);
  8967					clear_bit(Blocked, &rdev2->flags);
  8968					remove_and_add_spares(mddev, rdev2);
  8969				}
  8970			}
  8971		}
  8972	
  8973		/* recovery_cp changed */
  8974		if (le64_to_cpu(sb->resync_offset) != mddev->recovery_cp) {
> 8975			pr_info("%s:%d recovery_cp changed from %lu to %lu\n", __func__,
  8976					__LINE__, mddev->recovery_cp,
  8977					(unsigned long) le64_to_cpu(sb->resync_offset));
  8978			mddev->recovery_cp = le64_to_cpu(sb->resync_offset);
  8979		}
  8980	
  8981		/* Finally set the event to be up to date */
  8982		mddev->events = le64_to_cpu(sb->events);
  8983	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux