Shaohua Li <shli@xxxxxx> writes:
> If faulty disks of an array are more than allowed degraded number, the
> array enters error handling. It will be marked as read-only with
> MD_CHANGE_PENDING/RECOVERY_NEEDED set. But currently recovery doesn't
> clear CHANGE_PENDING bit for read-only array. If MD_CHANGE_PENDING is
> set for a raid5 array, all returned IO will be hold on a list till the
> bit is clear. But recovery nevery clears this bit, the IO is always in
> pending state and nevery finish. This has bad effects like upper layer
> can't get an IO error and the array can't be stopped.
>
> Signed-off-by: Shaohua Li <shli@xxxxxx>
> ---
> drivers/md/md.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 95824fb..c596b73 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -8209,6 +8209,7 @@ void md_check_recovery(struct mddev *mddev)
> md_reap_sync_thread(mddev);
> clear_bit(MD_RECOVERY_RECOVER, &mddev->recovery);
> clear_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
> + clear_bit(MD_CHANGE_PENDING, &mddev->flags);
> goto unlock;
> }
>
> --
> 1.8.1
Hi,
I can see that clearing MD_CHANGE_PENDING there is probably correct -
bug introduced by
Commit: c3cce6cda162 ("md/raid5: ensure device failure recorded before write request returns.")
However I don't understand your reasoning. You say that the array is
marked as read-only, but I don't see how that would happen. What
causes the array to be marked "read-only"?
Thanks,
NeilBrown
Attachment:
signature.asc
Description: PGP signature
