Change "mv $targetdir/log $logdir/$log" to "cp $targetdir/log $logdir/$log"

[Yi Zhang <yizhan@xxxxxxxxxx>]

Hi Neil
When I execute mdadm test with --save-logs set, found below error, could you help check it?

Error log:
tests/10ddf-fail-readd... FAILED - see /var/tmp/log-10ddf-fail-readd for details
cp: cannot stat ‘/var/tmp/log’: No such file or directory

Code:
    if ( set -ex ; . $_script ) &> $targetdir/log
    then
      echo "succeeded"
      _fail=0
    else
      log=log
      cat $targetdir/stderr >> $targetdir/log
      echo "=======================dmesg=================" >> $targetdir/log
      dmesg | tail -n 200 >> $targetdir/log
      if [ $exitonerror == 0 ]; then
          log=log-`basename $_script`
          mv $targetdir/log $logdir/$log                           // This step will move $targetdir/log to $logdir/$log,
      fi
      echo "FAILED - see $logdir/$log for details"
      _fail=1
    fi
    if [ "$savelogs" == "1" ]; then
      cp $targetdir/log $logdir/$_basename.log                     // If I set $savelogs here, the $targetdir/log doesn't exist now
    fi

So could we change the mv to cp?
diff --git a/test b/test
index d0a6cb8..118fa96 100755
--- a/test
+++ b/test
@@ -318,7 +318,7 @@ do_test() {
       dmesg | tail -n 200 >> $targetdir/log
       if [ $exitonerror == 0 ]; then
          log=log-`basename $_script`
-         mv $targetdir/log $logdir/$log
+         cp $targetdir/log $logdir/$log
       fi
       echo "FAILED - see $logdir/$log for details"
       _fail=1

Best Regards,
  Yi Zhang


--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html