> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Tuesday, September 1, 2015 11:53 PM > To: Song Liu > Cc: linux-raid@xxxxxxxxxxxxxxx; Shaohua Li; dan.j.williams@xxxxxxxxx; > neilb@xxxxxxx; hch@xxxxxxxxxxxxx > Subject: Re: [PATCH 2/6] Show device as journal in --detail --examine > > > #define MD_FEATURE_NEW_OFFSET 64 /* new_offset must > be honoured */ > > +#define MD_FEATURE_JOURNAL 512 /* support write > journal */ > > The kernel patches are using 256 here, so your userspace won't work with them > but rather generate very unhelpful warnings: > > [ 16.177710] md: sdc does not have a valid v1.2 superblock, not importing! > [ 16.178634] md: md_import_device returned -22 > mdadm: ADD_NEW_DISK for /dev/sdc failed: Invalid argument The latest kernel patches (now on Neil's devel branch) is using the following. We made this change because 256 is used by MD_FEATURE_CLUSTERED. #define MD_FEATURE_CLUSTERED 256 /* clustered MD */ #define MD_FEATURE_JOURNAL 512 /* support write cache */ -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
