On Thu, 11 Sep 2014 18:38:11 -0500 Brassow Jonathan <jbrassow@xxxxxxxxxx> wrote: > Neil (or anyone else), > > I know that trim/discard support was added back in 2012 (commit 9db90880). However, I thought there were still issues regarding what happens when various sync operations occur. I'd like to turn on discard support in dm-raid.c (a oneline patch) if things are in order. I can enable any, all or none depending on your recommendation. (I assume RAID1/10 is easier than the parity RAIDs.) The worst that a sync operation can do is report mismatches and "un-trim" some (or all) of some devices. It certainly should never corrupt data. My perception is that enabling discard support in the filesystem can be good for some devices and bad for other devices but should always be "safe" even when not "optimal". I think the same is true for md/raid. For raid5/6, we only honour discard if the underlying devices report discarded regions as all-zeros. That make it safe enough I believe. So I'd suggest: turn it on! NeilBrown
Attachment:
signature.asc
Description: PGP signature
