Re: [PATCH 1/1] Grow: Report when grow needs metadata update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 Aug 2014 20:47:12 +0000 Andy Smith <andy@xxxxxxxxxxxxxx> wrote:

> Report when the array's metadata needs updating instead of just
> reporting the generic "kernel too old" message.
> 
> Signed-off-by: Andy Smith <andy@xxxxxxxxxxxxxx>
> ---
>  Grow.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Grow.c b/Grow.c
> index a9c8589..76bb35a 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2255,7 +2255,9 @@ static int set_new_data_offset(struct mdinfo *sra, struct supertype *st,
>  		if (info2.space_before == 0 &&
>  		    info2.space_after == 0) {
>  			/* Metadata doesn't support data_offset changes */
> -			return 1;
> +			pr_err("%s: Metadata version doesn't support"
> +			       " data_offset changes\n", devname);
> +			goto release;
>  		}
>  		if (before > info2.space_before)
>  			before = info2.space_before;

Applied, thanks.

NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux