mdadm patch Monitor.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Neil,

Hopefully, you are still the maintainer of mdadm.
I would like to request the following trivial patch... pretty please!

--- Monitor.c	2014-08-21 05:16:56.000000000 -0500
+++ Monitor.c.new	2014-09-02 13:03:45.106590425 -0500
@@ -402,14 +402,12 @@
 			if (disc && disc[0] == ' ')
 				fprintf(mp, "Extra information:%s.\n\n", disc);

-			fprintf(mp, "Faithfully yours, etc.\n");
-
 			mdstat = fopen("/proc/mdstat", "r");
 			if (mdstat) {
 				char buf[8192];
 				int n;
 				fprintf(mp,
-					"\nP.S. The /proc/mdstat file"
+					"\nThe /proc/mdstat file"
 					" currently contains the following:\n\n");
 				while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
 					n=fwrite(buf, 1, n, mp);


The words removed above are superfluous and add no value to the message. In addition, they imply that the message is from a person, which is obviously not the case.

Cheers,

Phil


--
Phil Kauffman
Systems Admin
Dept. of Computer Science
University of Chicago
kauffman@xxxxxxxxxxxxxxx
773-702-3913
--- Monitor.c	2014-08-21 05:16:56.000000000 -0500
+++ Monitor.c.new	2014-09-02 13:03:45.106590425 -0500
@@ -402,14 +402,12 @@
 			if (disc && disc[0] == ' ')
 				fprintf(mp, "Extra information:%s.\n\n", disc);
 
-			fprintf(mp, "Faithfully yours, etc.\n");
-
 			mdstat = fopen("/proc/mdstat", "r");
 			if (mdstat) {
 				char buf[8192];
 				int n;
 				fprintf(mp,
-					"\nP.S. The /proc/mdstat file"
+					"\nThe /proc/mdstat file"
 					" currently contains the following:\n\n");
 				while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
 					n=fwrite(buf, 1, n, mp);

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux