Re: [PATCH] Parallel make bug in Makefile of mdadm-3.3.1 (corrupted udev rules and/or systemd services)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 17 Jul 2014 10:30:05 +0300 Samuli Suominen <ssuominen@xxxxxxxxxx>
wrote:

> If you run with:
> 
> $ export MAKEFLAGS="-j9"
> $ make install install-systemd
> 
> As in, combine "install" and "install-systemd" in the same command using
> parallel make,
> the content of .service files could end up in .rules, or otherway around
> because GNU
> make fill run them in parallel and the commands might ran at the same
> time, and both
> use same variables $file and same temporary files .install.tmp
> 
> This was reported at,
> https://bugs.gentoo.org/show_bug.cgi?id=517218
> 
> The immediate workaround is,
> 
> $ export MAKEFLAGS="-j9"
> $ make install
> $ make install-systemd
> 
> And the attach patch makes it full proof so they can be ran at the same
> line.
> 
> Thanks,
> Samuli

Hi,
 thanks for the bug report and the patch!

I don't think it is necessary to change the name for the variable (file ->
file1, file2 or file3).  Just leave it as 'file'.
However changing the name is important.  Could you send a patch which just
does that, and I'll apply it.

Also if the patch could be included inline in the mail, rather than as an
attachment, that would be nice.

(But if you don't want to bother, I'll make the fix anyway and credit you).

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux