On 04/11/2014 12:08 PM, Artur Paszkiewicz wrote: > On 04/10/2014 02:33 AM, NeilBrown wrote: >> On Wed, 9 Apr 2014 17:14:59 +0200 Artur Paszkiewicz >> <artur.paszkiewicz@xxxxxxxxx> wrote: >> >>> This modifies locking in Create to eliminate a situation where >>> --incremental can assemble a device between write_init_super() and >>> add_disk(), which causes Create to fail. >>> >>> It sporadically occurs e.g. when metadata is written on a device, >>> causing an udev change event which triggers mdadm --incremental. >>> >>> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@xxxxxxxxx> >> >> Thanks for the patch. >> I've taken the liberty of changing it a little. I didn't like the >> fact that >> we dropped the lock and then took it again. It probably doesn't >> matter, but >> it feels cleaner to hold it the whole time. >> >> So this is the result. Let me know if you disagree at all. > > Hello Neil, > > Your changes are OK, thanks. Hello Neil, Are you going to apply this patch? Thanks, Artur -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
