Hello Piergiorgio,
I'm going to review it in more detail later on this week and I think I
also still have an outstanding patch. But on quick glance, I think your
patch introduces a memory leak.
> @@ -152,13 +165,14 @@
char *stripe_buf = xmalloc(raid_disks * chunk_size);
char **stripes = xmalloc(raid_disks * sizeof(char*));
char **blocks = xmalloc(raid_disks * sizeof(char*));
+ char **blocks_page = xmalloc(raid_disks * sizeof(char*));
int *block_index_for_slot = xmalloc(raid_disks * sizeof(int));
uint8_t *p = xmalloc(chunk_size);
uint8_t *q = xmalloc(chunk_size);
int *results = xmalloc(chunk_size * sizeof(int));
sighandler_t *sig = xmalloc(3 * sizeof(sighandler_t));
I don't see free(blocks_page).
Btw, clangs static code checker is rather good to find such issues.
Actually, it reports several issues with mdadm, I just didn't have the
time to look into it in more detail.
Btw2: Any chance you could at least add the '-p' argument to your diff
command? I think if you just would use git, it would do that automatically.
Thanks,
Bernd
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
