Re: Remove bashism from Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Sep 2013 20:20:40 +0400 Michael Tokarev <mjt@xxxxxxxxxx> wrote:

> Makefile uses [ x == y ] construct which does not work
> with POSIX shell.  Since this is just testing a flag,
> replace it with string comparison (=) operator instead.
> 
> Signed-off-By: Michael Tokarev <mjt@xxxxxxxxxx>
> 
> diff --git a/Makefile b/Makefile
> index e8da3a5..c60cc2c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -156,7 +156,7 @@ all : check_rundir mdadm mdmon
>  man : mdadm.man md.man mdadm.conf.man mdmon.man raid6check.man
>  
>  check_rundir:
> -	@if [ ! -d "$(dir $(RUN_DIR))" -a  "$(CHECK_RUN_DIR)" == 1 ]; then \
> +	@if [ ! -d "$(dir $(RUN_DIR))" -a  "$(CHECK_RUN_DIR)" = 1 ]; then \
>  		echo "***** Parent of $(RUN_DIR) does not exist.  Maybe set different RUN_DIR="; \
>  		echo "*****  e.g. make RUN_DIR=/dev/.mdadm" ; \
>  		echo "***** or set CHECK_RUN_DIR=0"; exit 1; \

Applied, thanks.

NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux