On 09/10/2013 02:01 AM, NeilBrown wrote: >> Well, yast is actually not calling --brief. It calls "mdadm --examine >> --scan", and --scan implies --brief (comment in mdadm.c). My patch >> simply causes DDF and IMSM to print similar output with "mdadm -Es". >> Isn't that reasonable? > > This bit that I really didn't like is where you synthesised a "ddf_%d" name > if the name field was empty. This is wrong. Didn't really like it myself. Thanks for pointing it out. > There are a couple of other places where the name is extracted from the > ddf metadata: getinfo_super_ddf_bvd and container_content_ddf. > If brief_examine_subarrays_ddf uses the name in the same way following > the same rules (e.g. discarding trailing spaces) then that would be OK. > But if the name is empty, then no name should be given in the 'array' line. That means that libstorage's way of parsing mdadm -Es output must be changed, but that should be possible. Sending new patches. Martin -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
