On Sat, 2 Mar 2013 23:35:57 +0900 Akinobu Mita <akinobu.mita@xxxxxxxxx>
wrote:
> The value returned by test_and_set_bit_le() drivers/md/bitmap.c is not used.
> So just use set_bit_le(). The same goes for test_and_clear_bit_le().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Neil Brown <neilb@xxxxxxx>
> Cc: linux-raid@xxxxxxxxxxxxxxx
> ---
> drivers/md/bitmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 4fd9d6a..5a2c754 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -846,7 +846,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)
> if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
> set_bit(bit, kaddr);
> else
> - test_and_set_bit_le(bit, kaddr);
> + set_bit_le(bit, kaddr);
> kunmap_atomic(kaddr);
> pr_debug("set file bit %lu page %lu\n", bit, page->index);
> /* record page number so it gets flushed to disk when unplug occurs */
> @@ -868,7 +868,7 @@ static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block)
> if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
> clear_bit(bit, paddr);
> else
> - test_and_clear_bit_le(bit, paddr);
> + clear_bit_le(bit, paddr);
> kunmap_atomic(paddr);
> if (!test_page_attr(bitmap, page->index, BITMAP_PAGE_NEEDWRITE)) {
> set_page_attr(bitmap, page->index, BITMAP_PAGE_PENDING);
applied, thanks.
NeilBrown
Attachment:
signature.asc
Description: PGP signature
