Re: Set disk faulty / hot disk remove ioctl bug for read-only MD?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.02.2013 03:38, NeilBrown wrote:
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8b557d2..292cc2f 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6529,7 +6529,17 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,
>  			mddev->ro = 0;
>  			sysfs_notify_dirent_safe(mddev->sysfs_state);
>  			set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
> -			md_wakeup_thread(mddev->thread);
> +			/* mddev_unlock will wake thread */
> +			/* If a device failed while we were read-only, we
> +			 * need to make sure the metadata is updated now.
> +			 */
> +			if (test_bit(MD_CHANGE_DEVS, &mddev->flags)) {
> +				mddev_unlock(mddev);
> +				wait_event(mddev->sb_wait,
> +					   !test_bit(MD_CHANGE_DEVS, &mddev->flags) &&
> +					   !test_bit(MD_CHANGE_PENDING, &mddev->flags));
> +				mddev_lock(mddev);
> +			}
>  		} else {
>  			err = -EROFS;
>  			goto abort_unlock;
> 

Thanks, Neil!

I can confirm the issue on 3.4.y and that your patch fixes it reliably.

Acked-by: Sebastian Riemer <sebastian.riemer@xxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux