Re: [PATCH v2] mdadm: make --update=homehost work again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 6, 2013 at 4:53 PM, NeilBrown <neilb@xxxxxxx> wrote:
> On Wed,  6 Feb 2013 12:07:17 -0800 Justin Maggard <jmaggard10@xxxxxxxxx>
> wrote:
>
>> Commit 1e2b276535cea41c348292a019bdda8a58cb1679 (Report error in --update
>> string is not recognised) broke homehost updating functionality because it
>> depended on each string comparison being done even after we already found
>> a match.  Make it work again by using a goto instead.
>>
>
> Hi Justin,
> thanks for the patch.  Unfortunately I really don't like gotos when they can
> be easily avoided (though they do have their place sometimes).
> So I restructured the code a bit instead - as below.
>

Works for me.  Thanks!

-Justin
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux