Re: mdadm: error when using multiple ARRAY <ignore> lines in mdadm.conf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 11 Nov 2012 03:43:42 -0500 Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> the mdadm.conf documentation indicates that <ignore> is special and can be 
> specified multiple times.  unfortunately, that is not the case:
> 	mdadm: Device <ignore> given twice in config file
> 	mdadm: Duplicate MD device names in conf file were found.
> -mike

Fix by following patch.

thanks,
NeilBrown


From 13f2dd6be5618ff556f9a364903e4b95558115e1 Mon Sep 17 00:00:00 2001
From: NeilBrown <neilb@xxxxxxx>
Date: Thu, 22 Nov 2012 16:28:00 +1100
Subject: [PATCH] conf: allow multiple arrays to be <ignore>d

We currently complain if mdadm.conf contains multiple
definitions for the same name.  Unfortunately this stops
multiple arrays  from being <ignored>d.

So exclude "<ignore>" from the duplicate-names test.

Reported-by: Mike Frysinger <vapier@xxxxxxxxxx>
Signed-off-by: NeilBrown <neilb@xxxxxxx>

diff --git a/config.c b/config.c
index 656d4e2..8461309 100644
--- a/config.c
+++ b/config.c
@@ -1095,6 +1095,8 @@ int conf_verify_devnames(struct mddev_ident *array_list)
 	for (a1 = array_list; a1; a1 = a1->next) {
 		if (!a1->devname)
 			continue;
+		if (strcmp(a1->devname, "<ignore>") == 0)
+			continue;
 		for (a2 = a1->next; a2; a2 = a2->next) {
 			if (!a2->devname)
 				continue;

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux