On Thu, 08 Nov 2012 11:06:29 +0100
Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote:
> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Subject: [PATCH] raid5: panic() on dma_wait_for_async_tx() error
>
> There is not much we can do on dma_wait_for_async_tx() error
> so just panic() for now.
>
> Cc: Neil Brown <neilb@xxxxxxx>
> Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> Cc: Dan Williams <djbw@xxxxxx>
> Cc: Tomasz Figa <t.figa@xxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/md/raid5.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: b/drivers/md/raid5.c
> ===================================================================
> --- a/drivers/md/raid5.c 2012-11-07 16:25:19.480876012 +0100
> +++ b/drivers/md/raid5.c 2012-11-07 16:27:46.244875992 +0100
> @@ -3223,7 +3223,9 @@ static void handle_stripe_expansion(stru
> /* done submitting copies, wait for them to complete */
> if (tx) {
> async_tx_ack(tx);
> - dma_wait_for_async_tx(tx);
> + if (dma_wait_for_async_tx(tx) != DMA_SUCCESS)
> + panic("%s: DMA error waiting for transaction\n",
> + __func__);
Thats a really horrible place to panic.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
